fix(push-notifications): avoid duplicate macOS notification icons - #3114
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Desktop notifications always supplied
/icon-192.pngthrough the Web Notification API. On macOS, Electron displays this as a content image alongside the app icon macOS already adds, producing two BB logos.What changed
Omit the explicit notification icon when the desktop bridge identifies macOS. Keep the existing icon for web and Linux desktop notifications. Notification content, navigation, and deduplication remain unchanged.
How you verified
NODE_OPTIONS=--no-experimental-webstorage pnpm exec turbo run test typecheck --filter=bb-plugin-push-notificationspasses on Node 22.23.2. Disabling Node's experimental web storage lets jsdom own localStorage.notifications.testRPC. Observed Electron's Notification constructor receiving the title, body, and tag with no icon. Native delivery remained enabled during observation. Desktop logs showed no notification errors.Before and after
The after capture uses the source-built dev app, so the single application icon is Electron's development icon.